Skip to content

Commit

Permalink
Merge pull request #7877 from NixOS/backport-7856-to-2.12-maintenance
Browse files Browse the repository at this point in the history
[Backport 2.12-maintenance] Wait with making /etc unwritable until after build env setup
  • Loading branch information
thufschmitt authored Feb 22, 2023
2 parents 8639f41 + d13640f commit f12b158
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions src/libstore/build/local-derivation-goal.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1025,10 +1025,6 @@ void LocalDerivationGoal::startBuilder()
"nobody:x:65534:65534:Nobody:/:/noshell\n",
sandboxUid(), sandboxGid(), settings.sandboxBuildDir));

/* Make /etc unwritable */
if (!parsedDrv->useUidRange())
chmod_(chrootRootDir + "/etc", 0555);

/* Save the mount- and user namespace of the child. We have to do this
*before* the child does a chroot. */
sandboxMountNamespace = open(fmt("/proc/%d/ns/mnt", (pid_t) pid).c_str(), O_RDONLY);
Expand Down Expand Up @@ -1913,6 +1909,10 @@ void LocalDerivationGoal::runChild()
}
}

/* Make /etc unwritable */
if (!parsedDrv->useUidRange())
chmod_(chrootRootDir + "/etc", 0555);

/* Unshare this mount namespace. This is necessary because
pivot_root() below changes the root of the mount
namespace. This means that the call to setns() in
Expand Down

0 comments on commit f12b158

Please sign in to comment.