Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.13.0 regression: fetchTarball + channel: URL #7625

Closed
Kha opened this issue Jan 18, 2023 · 0 comments · Fixed by #7627
Closed

2.13.0 regression: fetchTarball + channel: URL #7625

Kha opened this issue Jan 18, 2023 · 0 comments · Fixed by #7627
Labels

Comments

@Kha
Copy link
Contributor

Kha commented Jan 18, 2023

Describe the bug

The fetchTarball builtin (and possibly others?) does not accept a channel: URL anymore, quoted or not.

Steps To Reproduce

$ nix run github:NixOS/nix/2.13.0 -- eval --impure --expr "fetchTarball \"channel:nixos-22.11\""
error:
       … while calling the 'fetchTarball' builtin

         at «string»:1:1:

            1| fetchTarball "channel:nixos-22.11"
             | ^

       error: unable to download 'channel:nixos-22.11': URL using bad/illegal format or missing URL (3)
$ nix run github:NixOS/nix/2.12.0 -- eval --impure --expr "fetchTarball \"channel:nixos-22.11\""
"/nix/store/i63d7z75f27p6388hzksamvir7zv7rbl-source"
$ nix run github:NixOS/nix/2.13.0 -- eval --impure --expr "fetchTarball channel:nixos-22.11"
error:
       … while calling the 'fetchTarball' builtin

         at «string»:1:1:

            1| fetchTarball channel:nixos-22.11
             | ^

       error: unable to download 'channel:nixos-22.11': URL using bad/illegal format or missing URL (3)
$ nix run github:NixOS/nix/2.12.0 -- eval --impure --expr "fetchTarball channel:nixos-22.11"
"/nix/store/i63d7z75f27p6388hzksamvir7zv7rbl-source"

Expected behavior

There should be no regression.

nix-env --version output

nix-env (Nix) 2.13.0

Additional context

I should probably update this code to --override-input, but I thought I should still flag the issue.

Priorities

Add 👍 to issues you find important.

@Kha Kha added the bug label Jan 18, 2023
edolstra added a commit to edolstra/nix that referenced this issue Jan 18, 2023
github-actions bot pushed a commit that referenced this issue Jan 18, 2023
iFreilicht pushed a commit to iFreilicht/nix that referenced this issue Jan 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant