Fix sudo in the darwin installer #10128
Conversation
Make sure that every part of the installer has access to the required environment to run our sudo wrapper
|
This is apparently also causing a failure in hydra: https://hydra.nixos.org/build/251925004/nixlog/1 |
|
(which is nice because it means that I can actually test it :) ) |
|
And I can confirm that this at least fixes the |
| fi | ||
| done | ||
|
|
||
| # Required by the darwin installer | ||
| export SUDO_KEPT_ENVIRONMENT_VARIABLES |
There was a problem hiding this comment.
Why does it need to be exported, if all we do with it is pass it through sudo?
There was a problem hiding this comment.
Frankly: I don't know. But it failed complaining that the variable was unset before. So I assume we're executing something in a sub-script somewhere
|
This broke the Ubuntu 16.04 installer, because their (probably very old) So either we
I'd be in favour of 1. now, and 3 after the release. Opinions? |
|
Yes, let's revert for now. We really have to make some progress on the installer situation more generally... |
This reverts commit 686405e.
This reverts commit 686405e.
This reverts commit 686405e.
This reverts commit 686405e.
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/2024-03-06-nix-team-meeting-131/42959/1 |
Motivation
Make sure that every part of the installer has access to the required environment to run our sudo wrapper
Context
The darwin installer job is broken on master: https://github.com/NixOS/nix/actions/runs/8112489666/job/22176091480
Seems to be due to #10070
Priorities and Process
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.