Fix warnings and optimize includes #11089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The move assignment was implicitly generated and used in
src/libstore/build/goal.cc:90:22:
90 | this->ex = std::move(*ex);
Clang warns about this generated method being deprecated, so making
them explicit fixes the warning.
roberth
added
the
contributor-experience
roberth
requested review from
Ericson2314,
fricklerhandwerk and
edolstra
as code owners
github-actions
bot
added
new-cli
Ericson2314
reviewed
Jul 12, 2024
Comment on lines
+76
to
+79
| for (auto _ : path) { | ||
| (void)_; | ||
| ++level; | ||
| } |
There was a problem hiding this comment.
Does this work?
Suggested change
| for (auto _ : path) { | |
| (void)_; | |
| ++level; | |
| } | |
| for (auto : path) ++level; |
See also std::distance
There was a problem hiding this comment.
Edit my suggestion did not. Let's try std::distance in a follow-up PR.
There was a problem hiding this comment.
Needs a difference member type. If we're adding members, I'd rather add an int depth() method that's implemented in whatever way.
For later.
edolstra
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
clangdreports a bunch about unused headers => solve warnings and make compilation slightly quickerContext
Priorities and Process
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.