builtin:fetchurl: Enable TLS verification #11585
Merged
+88
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is better for privacy and to avoid leaking netrc credentials in a MITM attack, but also the assumption that we check the hash no longer holds in some cases (in particular for impure derivations). Partially reverts 5db358d.
edolstra
added
backport 2.24-maintenance
roberth
approved these changes
Sep 25, 2024
roberth
added
backport 2.19-maintenance
edolstra
force-pushed
the
verify-tls
branch
from
de5edbb
to
7b39cd6
Compare
cole-h
reviewed
Sep 25, 2024
This was referenced Sep 25, 2024
edolstra
added a commit
that referenced
this pull request
Sep 25, 2024
…1585 builtin:fetchurl: Enable TLS verification (backport #11585)
edolstra
added a commit
that referenced
this pull request
Sep 25, 2024
…1585 builtin:fetchurl: Enable TLS verification (backport #11585)
edolstra
added a commit
that referenced
this pull request
Sep 25, 2024
…1585 builtin:fetchurl: Enable TLS verification (backport #11585)
edolstra
added a commit
that referenced
this pull request
Sep 25, 2024
…1585 builtin:fetchurl: Enable TLS verification (backport #11585)
edolstra
added a commit
that referenced
this pull request
Sep 25, 2024
…1585 builtin:fetchurl: Enable TLS verification (backport #11585)
edolstra
added a commit
that referenced
this pull request
Sep 25, 2024
…1585 builtin:fetchurl: Enable TLS verification (backport #11585)
edolstra
added a commit
that referenced
this pull request
Sep 25, 2024
…1585 builtin:fetchurl: Enable TLS verification (backport #11585)
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/nix-2-24-8-release-to-fix-builtin-fetchurl-security-issue/52732/1 |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
lf-
pushed a commit
to lix-project/lix
that referenced
this pull request
Sep 26, 2024
This is better for privacy and to avoid leaking netrc credentials in a MITM attack, but also the assumption that we check the hash no longer holds in some cases (in particular for impure derivations). Partially reverts NixOS/nix@5db358d. (cherry picked from commit c04bc17a5a0fdcb725a11ef6541f94730112e7b6) (cherry picked from commit f2f47fa725fc87bfb536de171a2ea81f2789c9fb) (cherry picked from commit 7b39cd631e0d3c3d238015c6f450c59bbc9cbc5b) Upstream-PR: NixOS/nix#11585 Change-Id: Ia973420f6098113da05a594d48394ce1fe41fbb9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Once upon a time we disabled this because we didn't have access to the certificates in the sandbox, and verification wasn't really needed because we're checking the hash of the download afterwards. But these days we do have access to certificates in the sandbox, and features like impure derivations make the second assumption no longer valid. So let's re-enable checking.
Context
Priorities and Process
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.