Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc, src: Fix various spelling typos #11611

Merged
merged 1 commit into from
Sep 29, 2024
Merged

doc, src: Fix various spelling typos #11611

merged 1 commit into from
Sep 29, 2024
+7 −8

Conversation

jljusten
Copy link
Contributor

Motivation

To fix various spelling issues flagged by the debian lintian tool.

@jljusten
doc, src: Fix various spelling typos
3b6cf35 
Signed-off-by: Jordan Justen <jljusten@gmail.com>
@github-actions github-actions bot added documentation new-cli Relating to the "nix" command store Issues and pull requests concerning the Nix store labels Sep 28, 2024
fricklerhandwerk
fricklerhandwerk approved these changes Sep 29, 2024
View reviewed changes
Copy link
Contributor

@fricklerhandwerk fricklerhandwerk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fricklerhandwerk
Copy link
Contributor

Btw have you considered adding that to CI checks?

@fricklerhandwerk fricklerhandwerk merged commit a141547 into NixOS:master Sep 29, 2024
10 checks passed
@jljusten
Copy link
Contributor Author

Btw have you considered adding that to CI checks?

This debian tool (lintian) is run on the output of the distro .deb files, but in looking at .github/workflows/ci.yml , I don't think any of the CI test paths attempt to run distro packaging.

I guess it seems likely that there is a generic tool that could run a spell check for pull requests though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fricklerhandwerk fricklerhandwerk fricklerhandwerk approved these changes

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314 Ericson2314 is a code owner

@edolstra edolstra Awaiting requested review from edolstra edolstra is a code owner

Assignees
No one assigned
Labels
documentation new-cli Relating to the "nix" command store Issues and pull requests concerning the Nix store
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jljusten @fricklerhandwerk