Move nixos tests #7648
Merged
Move nixos tests #7648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow contributors to find them more easily.
roberth
requested review from
fricklerhandwerk,
edolstra and
thufschmitt
as code owners
thufschmitt
approved these changes
Jan 20, 2023
roberth
commented
Jan 20, 2023
| imports = [ test ]; | ||
| hostPkgs = nixpkgsFor.${system}; | ||
| defaults = { | ||
| nixpkgs.pkgs = nixpkgsFor.${system}; |
There was a problem hiding this comment.
Tested with the assertion
assertions = [ { assertion = config.nix.package.drvPath == self.packages.${system}.default.drvPath; message = "Unexpected nix.package"; } ];
and checked that the assertion runs. ✔️
I'm not adding the assertion, because we may want to write a test which uses an older nix daemon. In other words the validity of the assertion is somewhat coincidental.
cole-h
reviewed
Jan 20, 2023
roberth
force-pushed
the
move-nixos-tests
branch
from
cfe6a35
to
3c08a3e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Move the integration tests together into a single directory, so that they're easier to find.
Use NixOS's public interface for calling the tests
Context
This came up in the final review of the PR template, #7577.
Checklist for maintainers
Maintainers: tick if completed or explain if not relevant
tests/**.shsrc/*/tests