libfetchers improvements without libflake
#9069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This helps ensure uniform docs/error message.
It isn't used, and doesn't belong in `libutil`.
It's not just flakes, but also `builtins.fetchTree`. Also try to provide some more info in general.
I don't know much about it, but by the number of times "flake" appears in the code it seems like is part of flakes, at least for now.
github-actions
bot
added
the
fetching
Ericson2314
changed the title
libfetchers improvements without libflake
fricklerhandwerk
approved these changes
Sep 29, 2023
|
Nice and concise. |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/2023-09-29-nix-team-meeting-minutes-90/33774/1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Cleaning up the code so we can better figure out what exactly we are stabilizing if we stabilize
builtins.fetchTree.Context
Avoiding the controversial part of #9063
Priorities
Add 👍 to pull requests you find important.