Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nix upgrade-nix: make the source URL an option #9333

Merged

Conversation

grahamc
Copy link
Member

@grahamc grahamc commented Nov 10, 2023

Motivation

This new option enables organizations to more easily manage their Nix fleet's deployment, and ensure a consistent and planned rollout of Nix upgrades.

Context

The current implementation requires remembering to specify an option every time nix upgrade-nix is called. However, that is error prone and causes issues for users and coordinated deployments.

Additionally, users may want to pin their upgrade source to a non-master version of Nixpkgs.

Priorities

Add 👍 to pull requests you find important.

This new option enables organizations to more easily manage their Nix
fleet's deployment, and ensure a consistent and planned rollout of Nix
upgrades.
Copy link
Contributor

@fricklerhandwerk fricklerhandwerk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It weirds me out that this lives in Nixpkgs, but that's out of scope here.

@thufschmitt thufschmitt merged commit 2afe2e4 into NixOS:master Nov 12, 2023
8 checks passed
@cole-h cole-h deleted the option-for-nix-upgrade-url branch November 12, 2023 19:02
@Ericson2314
Copy link
Member

It's better to create a new data type just for this command than put things in globals, to scope it's usage. (See nix daemon for how this works.) But this can be done in a follow-up PR.

@ghost
Copy link

ghost commented Nov 13, 2023

It weirds me out that this lives in Nixpkgs, but that's out of scope here.

There is a lot about nix upgrade-nix that weirds me out.

Although this PR is an improvement over what's in-tree, the underlying feature has essentially-unfixable design issues. For example, it is unfixably broken on:

  • musl-based systems
  • ILP32 systems, like the Apple Watch and mips64n32

I don't think this feature should be stabilized. If stabilizing it comes up for discussion, please let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation new-cli Relating to the "nix" command
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants