Convert --log-format to a setting
#9923
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`BaseSetting` is never used on its own, so it's fairly trivial to remove.
`fun` has a default value, so we no longer need to be able to convert `SettingHandler` to `bool`.
9999years
force-pushed
the
log-format-setting
branch
from
ed27bc1
to
edf5eb1
Compare
|
Note: This PR was intended to demonstrate the setting handler functionality added in #9922. That PR is more controversial than I anticipated, so I've refactored this PR to not depend on it. I do believe #9922 is worthwhile and it does make the implementation of the EDIT: Aaaactually I take that back. The |
9999years
force-pushed
the
log-format-setting
branch
from
edf5eb1
to
2df1524
Compare
9999years
force-pushed
the
log-format-setting
branch
from
2df1524
to
9e100ec
Compare
9999years
force-pushed
the
log-format-setting
branch
from
9e100ec
to
4c35ede
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This closes #5561 by adding a
log-formatsetting and avoids the issues of #8323 (namely, thatnixandnix-buildhave different default log formats) by adding alog-format-legacysetting to override thelog-formatsetting only for old-style commands likenix-build.Priorities
Add 👍 to pull requests you find important.