nodejs: run JS test suite as part of the checks

NixOS · May 23, 2024 · 7e800e8 · 7e800e8
1 parent 044fbf6
commit 7e800e8
Show file tree

Hide file tree

Showing 5 changed files with 28 additions and 2 deletions.
diff --git a/pkgs/development/web/nodejs/jstest-only-make-target.patch b/pkgs/development/web/nodejs/jstest-only-make-target.patch
@@ -0,0 +1,18 @@
+Add target to run JS test suite
+
+--- old/Makefile
++++ new/Makefile
+@@ -305,4 +305,12 @@ v8:
+
++.PHONY: jstest-no-addons
++jstest-no-addons: CI_SKIP_TESTS=addons
++jstest-no-addons: jstest-only
++
+ .PHONY: jstest
+-jstest: build-addons build-js-native-api-tests build-node-api-tests ## Runs addon tests and JS tests
++jstest: build-addons build-js-native-api-tests build-node-api-tests jstest-only ## Runs addon tests and JS tests
++
++.PHONY: jstest-only
++.NOTPARALLEL: jstest-only
++jstest-only:
+        $(PYTHON) tools/test.py $(PARALLEL_ARGS) --mode=$(BUILDTYPE_LOWER) \
diff --git a/pkgs/development/web/nodejs/nodejs.nix b/pkgs/development/web/nodejs/nodejs.nix
@@ -137,10 +137,15 @@ let
       "build-node-api-tests"
       "tooltest"
       "cctest"
+      "jstest-only"
     ];
 
-    # Do not create __pycache__ when running tests.
-    checkFlags = [ "PYTHONDONTWRITEBYTECODE=1" ];
+    checkFlags = [
+      # Do not create __pycache__ when running tests.
+      "PYTHONDONTWRITEBYTECODE=1"
+      # Skip some tests that are not passing in this context
+      "CI_SKIP_TESTS=addons,test-setproctitle,test-tls-client-auth,test-tls-sni-option,test-https-foafssl"
+    ];
 
     postInstall = ''
       HOST_PATH=$out/bin patchShebangs --host $out

diff --git a/pkgs/development/web/nodejs/v18.nix b/pkgs/development/web/nodejs/v18.nix
@@ -27,5 +27,6 @@ buildNodejs {
     ./revert-arm64-pointer-auth.patch
     ./node-npm-build-npm-package-logic.patch
     ./trap-handler-backport.patch
+    ./jstest-only-make-target.patch
   ];
 }
diff --git a/pkgs/development/web/nodejs/v20.nix b/pkgs/development/web/nodejs/v20.nix
@@ -15,5 +15,6 @@ buildNodejs {
     ./disable-darwin-v8-system-instrumentation-node19.patch
     ./bypass-darwin-xcrun-node16.patch
     ./node-npm-build-npm-package-logic.patch
+    ./jstest-only-make-target.patch
   ];
 }
diff --git a/pkgs/development/web/nodejs/v22.nix b/pkgs/development/web/nodejs/v22.nix
@@ -14,5 +14,6 @@ buildNodejs {
     ./disable-darwin-v8-system-instrumentation-node19.patch
     ./bypass-darwin-xcrun-node16.patch
     ./node-npm-build-npm-package-logic.patch
+    ./jstest-only-make-target.patch
   ];
 }