Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling plymouth hides ZFS password prompt #44965

Open
ElvishJerricco opened this issue Aug 13, 2018 · 15 comments
Open

Enabling plymouth hides ZFS password prompt #44965

ElvishJerricco opened this issue Aug 13, 2018 · 15 comments

Comments

@ElvishJerricco
Copy link
Contributor

Issue description

Enabling the boot.plymouth.enable option on a system with a ZFS root with encryption enabled will cause the password prompt to be hidden at boot. You can still blindly type the password in, but this is not obvious.

Technical details

We do have something for LUKS, but it seems ZFS prompts at a different time in the lifecycle.

As an aside, plymouth does have an option for prompting for a password graphically. It'd be neat if we could use this for encrypted file systems. Then we could hide all text output and just show the splash.

@jtojnar
Copy link
Member

jtojnar commented Aug 13, 2018

For the record, it does not show the graphical prompt with LUKS either: #26722

@infinisil
Copy link
Member

I just ran into this when I enabled encryption yesterday. I discussed potential solutions with @samueldr on IRC. The most elegant imo would be to restructure the initrd script into something similar to activationScripts, where you can set dependencies between phases, preferably using @rycee's DAG library.

@cleverca22
Copy link
Contributor

2 solutions for this:
1: https://wiki.ubuntu.com/Plymouth#A.22plymouth_ask-for-password.22
2:

[root@amd-nixos:~]# plymouth --help
 show-splash        Tell daemon to show splash screen
 hide-splash        Tell daemon to hide splash screen

you can just hide/show the splash, to let the text console prompt things

@stale
Copy link

stale bot commented Jun 2, 2020

Thank you for your contributions.

This has been automatically marked as stale because it has had no activity for 180 days.

If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.

Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse.
  3. Ask on the #nixos channel on irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 2, 2020
@cole-h
Copy link
Member

cole-h commented Jun 2, 2020

I believe #88789 will fix this once it's merged. I just rebooted my system and found that I was not using that branch, because there was no prompt and I had to blindly enter my password. However, using that branch, I was prompted for my password via plymouth as one would hope/expect.

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 2, 2020
@stale
Copy link

stale bot commented Nov 29, 2020

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Nov 29, 2020
@nh2
Copy link
Contributor

nh2 commented Nov 29, 2020

Still important to me

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Nov 29, 2020
@stale
Copy link

stale bot commented Jun 3, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 3, 2021
@misuzu
Copy link
Contributor

misuzu commented Jun 18, 2021

Bump.

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 18, 2021
@stale
Copy link

stale bot commented May 2, 2022

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label May 2, 2022
@betaboon
Copy link
Contributor

betaboon commented May 2, 2022

Still important to me

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label May 2, 2022
@Majiir
Copy link
Contributor

Majiir commented Aug 16, 2022

This is now working on nixos-unstable (after #179619 merged) as long as you also set boot.initrd.systemd.enable = true in your config. Fair warning, that option says:

Note: This is in very early development and is highly experimental. Most of the features NixOS supports in initrd are not yet supported by the intrd generated with this option.

@ElvishJerricco
Copy link
Contributor Author

That note as it's currently written is a little outdated. It's definitely still experimental, but I wouldn't say highly experimental anymore. Quite a few of us actually daily drive it with a variety of fancy initrd use cases. And at this point we do actually support most of what the old scripted initrd supports; we're pretty much just missing networking (#169116 is near completion for that), and some of the fancier LUKS options.

@Majiir
Copy link
Contributor

Majiir commented Aug 25, 2023

Closing this as completed. For future readers, ZFS+Plymouth works if you set boot.initrd.systemd.enable = true. This enables the systemd initrd, which replaces the older script-based stage 1 initrd.

See #26722 for a similar issue about LUKS+Plymouth.

@Majiir Majiir closed this as completed Aug 25, 2023
@ElvishJerricco
Copy link
Contributor Author

@Majiir I disagree with closing this. Systemd initrd is still marked experimental and is not feature complete. The default initrd in NixOS has this issue.

@ElvishJerricco ElvishJerricco reopened this Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants