retroarch: fix build on Darwin #102230
Closed
retroarch: fix build on Darwin #102230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SuperSandro2000 can you give these a try? |
|
Result of Currently looking why wayland is pulled in. |
I didn't add that change yet, only the ones in the libretro cores. |
diff --git a/pkgs/misc/emulators/retroarch/default.nix b/pkgs/misc/emulators/retroarch/default.nix
index bfc2c338769..669ffd7e79b 100644
--- a/pkgs/misc/emulators/retroarch/default.nix
+++ b/pkgs/misc/emulators/retroarch/default.nix
@@ -32,8 +32,9 @@ stdenv.mkDerivation rec {
rev = "v${version}";
};
- nativeBuildInputs = [ pkgconfig wayland ]
- ++ optional withVulkan makeWrapper;
+ nativeBuildInputs = [ pkgconfig ]
+ ++ optional withVulkan makeWrapper
+ ++ optional stdenv.isLinux wayland;
buildInputs = [ ffmpeg_3 freetype libxml2 libGLU libGL python3 SDL2 which ]
++ optional enableNvidiaCgToolkit nvidia_cg_toolkitbut then it still fails with: |
|
Ok, looks like I forgot the current MAME core. Meanwhile can you try to build |
|
Result of 4 packages built:
|
Builds for me with my change. |
It was found out in the course of NixOS#102078 that the libretro.mame* packages did not build on macOS, both because of an unconditional dependency on alsa-lib (which is exclusive to Linux) and references to GCC scattered across makefiles. This commit makes alsa-lib a dependency only on Linux, and tries to force usage of the generic `cc`/`c++` commands. Ideally we'd refer to the `$CC` and `$CXX` environment variables, but that seems to introduce recursive expansion problems for make. Thanks to @SuperSandro2000 for suggestions and actual testing.
Wayland is not used or supported in other platforms.
AluisioASG
force-pushed
the
aasg/retroarch-darwin
branch
from
a2049b5
to
34fe576
Compare
AluisioASG
changed the title
|
The latest push should make it all work. |
ofborg
bot
added
10.rebuild-darwin: 11-100
10.rebuild-linux: 11-100
and removed
10.rebuild-darwin: 1-10
10.rebuild-linux: 1-10
labels
|
Result of 76 packages built:
|
|
Result of 1 package marked as broken and skipped:
12 packages failed to build:
60 packages built:
atari800 beetle-psx-hw citra fbneo mame mame2016 mupen64plus picodrive play ppsspp vecx |
|
fbalpga2012 |
|
@AluisioASG hit me up on IRC if you want to debug this together with less delay between tests. |
|
Result of 1 package marked as broken and skipped:
10 packages failed to build:
61 packages built:
beetle-psx-hw citra fbalpha2012 fbneo mame https://termbin.com/li6zd mame2016 https://termbin.com/smc4z picodrive play ppsspp |
|
citra https://termbin.com/m2tl dolphin mame 2016 https://termbin.com/znfj1 |
|
Citra seems to require a newer macOS. Dolphin and MAME just need playing whack-a-mole with macOS' frameworks. |
|
That seems to be mamedev/mame#2598, hopefully a patch applies cleanly. |
|
Result of 6 packages marked as broken and skipped:
4 packages failed to build:
63 packages built:
dolphin mame: still the log above play: Missing Foundation Framework ppsspp |
|
Dolphin was configured to link statically, the commit that set that doesn't say why. Apparently Dolphin, MAME, and Play had references to Foundation, so I added a dependency to it for them. |
|
Result of 6 packages marked as broken and skipped:
1 package failed to build:
66 packages built:
|
AluisioASG
added a commit
to AluisioASG/nixexprs
that referenced
this pull request
Nov 4, 2020
After spending a massive amount of time making RetroArch build on macOS (github:NixOS/nixpkgs#102230), I've decided to make sure my packages have the right platforms on their `meta.platforms` and `meta.broken`. Looks like builds.sr.ht has FreeBSD images. Might try to build for that later.
AluisioASG
added a commit
to AluisioASG/nixexprs
that referenced
this pull request
Nov 4, 2020
After spending a massive amount of time making RetroArch build on macOS (github:NixOS/nixpkgs#102230), I've decided to make sure my packages have the right platforms on their `meta.platforms` and `meta.broken`. Looks like builds.sr.ht has FreeBSD images. Might try to build for that later.
AluisioASG
added a commit
to AluisioASG/nixexprs
that referenced
this pull request
Nov 4, 2020
After spending a massive amount of time making RetroArch build on macOS (github:NixOS/nixpkgs#102230), I've decided to make sure my packages have the right platforms on their `meta.platforms` and `meta.broken`. Looks like builds.sr.ht has FreeBSD images. Might try to build for that later.
AluisioASG
added a commit
to AluisioASG/nixexprs
that referenced
this pull request
Nov 4, 2020
After spending a massive amount of time making RetroArch build on macOS (github:NixOS/nixpkgs#102230), I've decided to make sure my packages have the right platforms on their `meta.platforms` and `meta.broken`. Looks like builds.sr.ht has FreeBSD images. Might try to build for that later.
AluisioASG
force-pushed
the
aasg/retroarch-darwin
branch
2 times, most recently
from
385f7a3
to
1ee1443
Compare
AluisioASG
force-pushed
the
aasg/retroarch-darwin
branch
2 times, most recently
from
befc508
to
ac211b0
Compare
|
Result of 2 packages failed to build:
74 packages built:
libretro.dolphin: libretro.mame: timed out Edit: Can we set some flag to only compile mame* on big compilers like libreoffice? Each of them took ~40 minutes on my not terrible machine. |
|
Result of 6 packages marked as broken and skipped:
14 packages failed to build:
53 packages built:
beetle-gba: beetl-lynx beetle-pcfx beetle-snes: beetle-supergrafx beetle-vb: beetle-wswan: libretro.desmume libretro.desmume2015 libretro.dosbox libretro.gambatte libretro.mame libretro.stella2014 libretro.tgbdual |
10 tasks
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
|
Closing as dead and conflicted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The newer MAME cores for libretro don't seem to build on Darwin (probably not on BSD either). See comments in #102078.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)