Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KDE Gear 21.04.0 #120514

Merged
merged 19 commits into from
May 12, 2021
Merged

KDE Gear 21.04.0 #120514

merged 19 commits into from
May 12, 2021

Conversation

ttuegel
Copy link
Member

@ttuegel ttuegel commented Apr 24, 2021

Motivation for this change
  • Update KDE Applications 20.12.3 to KDE Gear 21.04.0.
  • Change the attribute name from kdeApplications to kdeGear.

Attn: @NixOS/qt-kde

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Apr 25, 2021

I think we should add an alias from kdeApplications to kdeGear.

@FRidh
Copy link
Member

FRidh commented Apr 25, 2021

@GrahamcOfBorg eval

@schmittlauch
Copy link
Member

I'd be willing to test some of this, but am not sure whether this is possible from a 20.09 installation. Mixing Qt versions running in parallel is still problematic, isn't it?

@ttuegel ttuegel force-pushed the kde-gear-21.04.0 branch 3 times, most recently from 84d12f5 to a6d55a7 Compare May 3, 2021 15:46
@mweinelt mweinelt added this to the 21.05 milestone May 3, 2021
@ttuegel
Copy link
Member Author

ttuegel commented May 3, 2021

@SuperSandro2000 Is there a way to add a nested alias to alias.nix, or do we need to add an alias directly to qt-packages.nix?

@ttuegel ttuegel merged commit f99ac85 into NixOS:staging May 12, 2021
@ttuegel ttuegel deleted the kde-gear-21.04.0 branch May 12, 2021 10:58
@SuperSandro2000
Copy link
Member

@SuperSandro2000 Is there a way to add a nested alias to alias.nix, or do we need to add an alias directly to qt-packages.nix?

Not fully sure. Some examples are here https://github.com/NixOS/nixpkgs/blob/master/pkgs/top-level/aliases.nix#L751 and here https://github.com/NixOS/nixpkgs/blob/master/pkgs/top-level/aliases.nix#L944

Also I think you missed https://github.com/NixOS/nixpkgs/blob/21.05/pkgs/top-level/all-packages.nix#L17598

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants