Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.databases: 0.2.6 -> 0.4.3 #122125

Closed
wants to merge 1 commit into from
Closed

python3Packages.databases: 0.2.6 -> 0.4.3 #122125

wants to merge 1 commit into from

Conversation

mweinelt
Copy link
Member

@mweinelt mweinelt commented May 7, 2021

Aaaaand fix the tests.

Motivation for this change

Also fixes starlette.

ZHF #122042

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

kalekseev
kalekseev reviewed May 7, 2021
View reviewed changes
pkgs/development/python-modules/databases/default.nix
Comment on lines +40 to +42
# imports pymysql.util, which doesn't exist in pymysql>1.0
# https://github.com/encode/databases/issues/330
"tests/test_connection_options.py"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be fixed by this #122126

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, looks better.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

databases just imports aiomysql and it was broken in nixpkgs because requirements were patched to allow PyMySQL 1.0 while aimysql wasn't patched, so that issue has nothing with databases, encode/databases#330 should be probably closed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The patch you are pulling isn't merged in aiomysql either, so I consider this issue to still be relevant.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it's not pulled but if you install databases with pip then aiomysql will require PyMySQL < 1.0. That issue is caused by this patch https://github.com/NixOS/nixpkgs/blob/029d5b2fc2b9db1f401a89c1c242024fcbc36d47/pkgs/development/python-modules/aiomysql/default.nix#L37-L40

@mweinelt mweinelt marked this pull request as draft May 7, 2021 23:11
@mweinelt mweinelt closed this May 7, 2021
@mweinelt mweinelt deleted the python/databases branch May 7, 2021 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalekseev kalekseev kalekseev left review comments

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mweinelt @kalekseev