-
-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plasma5: 5.22.0 -> 5.23.1 #139657
plasma5: 5.22.0 -> 5.23.1 #139657
Conversation
fdf104c
to
45c14cc
Compare
FYI: there's a patch to fix the "Other" option in sddm. It will be included in 5.23.1, but many distros are backporting it: https://invent.kde.org/plasma/plasma-workspace/-/commit/d5a3e749a30613294f41386180aaf31dfb1a9bee Not sure if it's worth backporting it here though since reviewing Plasma updates usually takes some time and so 5.23.1 might be out by the time this is ready to merge… |
10e6842
to
060d3ba
Compare
@InternetUnexplorer included patch |
file(GLOB_RECURSE GTK2_SOURCES "gtk2/*") | ||
|
||
-configure_file(build_theme.sh.cmake ${CMAKE_CURRENT_BINARY_DIR}/build_theme.sh @ONLY) | ||
+configure_file(build_theme.sh.cmake ${CMAKE_CURRENT_BINARY_DIR}/build_theme.sh FILE_PERMISSIONS OWNER_READ OWNER_WRITE OWNER_EXECUTE GROUP_READ GROUP_EXECUTE WORLD_READ WORLD_EXECUTE @ONLY) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick: Wouldn't better to simply add a chmod +x
on preBuild
or something like that, instead of a full patch? Would be easier to overwrite/inspect and less prone to getting out of date.
This version with kf5.87 has the same bug I saw in #141670: clock is not shown, and clicking on its space shows calendar with some mock values and non-interpolated format strings: |
For some unknown reason I just got this with nixos-unstable. Maybe it doesn't have a causality with this update? Or did something update in nixos-unstable. I don't have the time to further investigate right now. good: e4ef597 bad: 9aeeb75 |
@andrevmatos Could you please test with reverting 763a001 and 4832352 |
#100057 (comment) maybe also try deleting the cache first (I didn't have time yet to do that) |
Didn't change anything for me. |
@andrevmatos Possibly you had the same problem that I had. The referenced commits reset my default to wayland. Check in your settings/on the login screen if that's the case. Otherwise this may be something different. |
5.23.1 is already out. Could you also include the patch for https://bugs.kde.org/show_bug.cgi?id=438839 ? Since we have plasma wayland now, this crash issue is quite easy to run into if you have only one monitor. |
For wayland #100057 (comment) worked for me. |
Given that Plasma is an important part of the NixOS ISO, and the release feature freeze is looming, would you be willing to rebase on the latest Plasma as @oxalica has suggested? We really should have the latest version at release time if at all feasible. |
Signed-off-by: Yaroslav Bolyukin <iam@lach.pw>
Signed-off-by: Yaroslav Bolyukin <iam@lach.pw>
Signed-off-by: Yaroslav Bolyukin <iam@lach.pw>
Signed-off-by: Yaroslav Bolyukin <iam@lach.pw>
Signed-off-by: Yaroslav Bolyukin <iam@lach.pw>
Signed-off-by: Yaroslav Bolyukin <iam@lach.pw>
Signed-off-by: Yaroslav Bolyukin <iam@lach.pw>
Signed-off-by: Yaroslav Bolyukin <iam@lach.pw>
Signed-off-by: Yaroslav Bolyukin <iam@lach.pw>
Signed-off-by: Yaroslav Bolyukin <iam@lach.pw>
Signed-off-by: Yaroslav Bolyukin <iam@lach.pw>
060d3ba
to
f45e4ff
Compare
I tried this PR and it works almost fine on X11 and no critical issues on wayland. Here are some issues I met,
Note that (2) can be the cause of (1) since @mohe2015 in #100057 (comment) reported that without |
The Wayland clock widget issue is resolved by not declaring any timezone in the system configuration, but it then defaults to UTC. |
The date bug has been ongoing, and is present in 5.22.5. It brakes |
@@ -24,10 +24,6 @@ mkDerivation { | |||
mobile-broadband-provider-info openconnect | |||
]; | |||
patches = [ | |||
(substituteAll { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this patch no longer needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mobile-broadband path is now fetched from CMake, instead of being hardcoded; this makes it work ootb on nixos
SDDM defaulted to the Plasma Wayland session for me, which gives a bad experience because Wayland is so broken. Is that an intentional effect of this pull request, or is it just some bad state left over state from my testing something else? |
This happened to me too. I think it's because the sessions are sorted alphabetically and it chooses the first one. There seems to be sddm/sddm#326. |
There is also discussion of this on #100057, so at least we know it's unrelated to this pull request. |
🤔 Seems 5.23.2 is just released one day ago. https://invent.kde.org/plasma/plasma-workspace/-/tree/v5.23.2 |
Motivation for this change
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)