Move all aliases into their own file. #14029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| xlibs = xorg; # added 2015-09 | ||
| youtubeDL = youtube-dl; # added 2014-10-26 | ||
| }; | ||
| aliases = import ./alias-packages.nix self; |
There was a problem hiding this comment.
why not just aliases.nix ? naming :)
|
LGTM otherwise |
|
I will apply the comments, and merge the patch. |
|
cc @edolstra |
nbp
added a commit
that referenced
this pull request
Mar 18, 2016
Move all aliases into their own file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done:
nix-shell -p nox --run "nox-review wip"This patch just move a sub-part of all-packages into its own file. I am separating this change from #14000, because it will bitrot quickly and force the rebase of the changes everytime.
This work is needed for making seamless security updates (#10851), as we would have to replace the
aliasesvariable by another one taken from another tree.