spidermonkey_68: drop

[Mic92]

Motivation for this change

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 22.05 Release Notes (or backporting 21.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
  • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
• Fits CONTRIBUTING.md.

[ajs124]

LGTM

[jtojnar]

libproxy does not support spidermonkey other than 68. It builds with a different version because the cmake flag is broken and pacrunner_mozjs is not built: libproxy/libproxy#153

[lostnet]

Maybe it would make sense to remove js support in libproxy outside of darwin since it doesn't build anyway.

• It is misleading since it doesn't do anything.
• If the prediction that the next version supports esr78 is right, it is already out of esr maintenance.
• If the reference is optimistically changed to esr91 it will add a lot of build dependencies for esr updates in the interim for something non-functional.
• The Duktape pacrunner is already integrated so it should be evaluated and might be the better choice when the next version releases.

[jtojnar]

cc @zhaofengli who implemented the Duktape support.

[zhaofengli]

I agree with @lostnet. It doesn't make sense to have a mozjs dependency that isn't actually used. For Duktape, maybe we can ask the upstream to cut a release.

[zhaofengli]

I asked upstream here.