-
-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixos/plymouth: Add systemd stage 1 support #170136
nixos/plymouth: Add systemd stage 1 support #170136
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, some follow-up tasks were added to the board.
@@ -198,18 +282,18 @@ in | |||
EOF | |||
''; | |||
|
|||
boot.initrd.extraUtilsCommandsTest = '' | |||
boot.initrd.extraUtilsCommandsTest = mkIf (!config.boot.initrd.enable) '' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this option (here and below) supposed to be !config.boot.initrd.enable
or !config.boot.initrd.systemd.enable
?
(I don’t get a plymouth bootsplash anymore since my latest update)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix: #174090
Description of changes
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes