Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskell: move generateOptparseApplicativeCompletions into pkg sets for cross support #190536

Merged
merged 2 commits into from
Oct 6, 2022
Merged

haskell: move generateOptparseApplicativeCompletions into pkg sets for cross support #190536

merged 2 commits into from
Oct 6, 2022

Commits on Oct 6, 2022

  1. haskell: support cross in generateOptparseApplicativeCompletions 

    Deprecate haskell.lib{,.compose}.generateOptparseApplicativeCompletion*
in favor of the newly added
haskell.packages.*.generateOptparseApplicativeCompletions (plural!)
which takes into account whether we are cross-compiling or not. If we
are, generating completions is disabled, since we can't execute software
built for a different platform.

The move is necessary, so we can receive the /same/ stdenv as the
package we are overriding in order to accurately check whether we can
execute produced binaries.

Resolves NixOS#174040.
Resolves NixOS#49648.
    @sternenseemann
    sternenseemann committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    0e9db81 View commit details
    Browse the repository at this point in the history

  2. haskell.lib.compose.addOptparseApplicativeCompletionScripts: remove 

    This function was deprecated when it was first added to
haskell.lib.compose, so we can probably safely drop it.
    @sternenseemann
    sternenseemann committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    68df602 View commit details
    Browse the repository at this point in the history