lz4: fix static build

[robx]

Description of changes

This patches lz4 with lz4/lz4#1162, fixing the static build.

Before this, I see

$ nix build nixpkgs#pkgsStatic.lz4
error: builder for '/nix/store/4ssbvpxh8bp5gdk7517ip22myl6b39an-lz4-static-x86_64-unknown-linux-musl-1.9.4.drv' failed with exit code 2;
       last 10 log lines:
       > build flags: -j2 -l2 SHELL=/nix/store/p7bpdnxqd3i5hwm92mrscf7mvxk66404-bash-5.1-p16/bin/bash PREFIX=\$\(out\) INCLUDEDIR=\$\(dev\)/include BUILD_STATIC=yes BUILD_SHARED=no WINDRES:=x86_64-unknown-linux-musl-windres
       > make[1]: Entering directory '/build/source/lib'
       > compiling static library
       > compiling dynamic library 1.9.4
       > /nix/store/q8zpwwa77zaa5h0p15iiid26g5ak6s7l-x86_64-unknown-linux-musl-binutils-2.38/bin/x86_64-unknown-linux-musl-ld: /nix/store/ravnd17fg4maxzc5ns8vbijn7ah3p4b1-x86_64-unknown-linux-musl-stage-final-gcc-11.3.0/lib/gcc/x86_64-unknown-linux-musl/11.3.0/crtbeginT.o: relocation R_X86_64_32 against hidden symbol `__TMC_END__' can not be used when making a shared object
       > /nix/store/q8zpwwa77zaa5h0p15iiid26g5ak6s7l-x86_64-unknown-linux-musl-binutils-2.38/bin/x86_64-unknown-linux-musl-ld: failed to set dynamic section sizes: bad value
       > collect2: error: ld returned 1 exit status
       > make[1]: *** [Makefile:122: liblz4.so.1.9.4] Error 1
       > make[1]: Leaving directory '/build/source/lib'
       > make: *** [Makefile:57: lib-release] Error 2

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 22.11 Release Notes (or backporting 22.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
  • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
• Fits CONTRIBUTING.md.

[robx]

(that CI error seems due to a full disk, error: creating directory '/nix/store/add-3770538-0/x/pkgs/applications/version-management/gitea': No space left on device)

[superherointj]

Shouldn't this PR be targeting staging?

[robx]

Shouldn't this PR be targeting staging?

I don't know. Happy to update if it should.

[superherointj]

I don't know. Happy to update if it should.

It causes downstream upgrade of 18463 packages.

[robx]

I don't know. Happy to update if it should.

It causes downstream upgrade of 18463 packages.

I guess that's a yes? So I'll rebase this on top of staging, and change the PR base to staging?

[superherointj]

I guess that's a yes? So I'll rebase this on top of staging, and change the PR base to staging?

Yes.

[superherointj]

I can build lz4 from this PR. I have not tested downstream breakage because it is just too large.