Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libxml2: 2.10.0 → 2.10.2 #195748

Merged
merged 2 commits into from
Oct 13, 2022
Merged

libxml2: 2.10.0 → 2.10.2 #195748

merged 2 commits into from
Oct 13, 2022

Conversation

jtojnar
Copy link
Member

@jtojnar jtojnar commented Oct 13, 2022 •
edited by mweinelt
Loading

Description of changes

Without this, parsing HTML using DomDocument when running a script using mod_php on Apache seems to create an empty document: https://gitlab.gnome.org/GNOME/libxml2/-/issues/399

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from edolstra October 13, 2022 01:41
@jtojnar jtojnar changed the title libxslt: 1.1.36 → 1.1.37 libxml2: 2.10.0 → 2.10.2 Oct 13, 2022
@jtojnar jtojnar mentioned this pull request Oct 13, 2022
Closed
31 tasks
@drupol
Copy link
Contributor

drupol commented Oct 13, 2022

Nice !

@mweinelt
Copy link
Member

Doesn't break any of postgresql's tests, so I think we'll give it a shot.

@mweinelt mweinelt merged commit ef6a273 into NixOS:staging Oct 13, 2022
@jtojnar jtojnar deleted the libxml2 branch October 13, 2022 17:02
@vcunat
Copy link
Member

vcunat commented Oct 14, 2022

Broke stdenv bootstrapping on darwin:
https://hydra.nixos.org/log/c1xy2yq1rglnahjzgkrb2g2hg6y8rr5k-libxml2-2.10.2.drv
https://hydra.nixos.org/log/qv843asd2ddf7f3l04kgcqcg89iwrxzp-libxml2-2.10.2.drv

/cc PR #195862

@jtojnar
Copy link
Member Author

jtojnar commented Oct 14, 2022

This is probably caused by the removal of generated files from the tarball requiring us to build them ourselves. And that likely fails because expat is not available in the python used for the build.

vcunat added a commit that referenced this pull request Oct 15, 2022
@vcunat
libxml2: use older version during stdenv bootstrap on darwin
36bb8d9 
/cc the update PR #195748
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drupol drupol drupol approved these changes

@edolstra edolstra Awaiting requested review from edolstra

Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-darwin-stdenv 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+ 11.by: package-maintainer 12.approvals: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jtojnar @drupol @mweinelt @vcunat @bobby285271