Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aspellDicts.is, aspellDicts.nb: fix build on darwin #199400

Merged
merged 1 commit into from
Nov 7, 2022
Merged

aspellDicts.is, aspellDicts.nb: fix build on darwin #199400

merged 1 commit into from
Nov 7, 2022

Conversation

wegank
Copy link
Member

@wegank wegank commented Nov 3, 2022 •
edited
Loading

Description of changes

ZHF #199919.

(Maybe also Homebrew/homebrew-core#28074?)

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@wegank wegank marked this pull request as draft November 3, 2022 21:05
@wegank wegank force-pushed the aspelldicts-darwin branch 2 times, most recently from e4eb758 to 79a62d7 Compare November 4, 2022 00:09
@wegank wegank marked this pull request as ready for review November 4, 2022 00:09
@bjornfor bjornfor merged commit 2d1dc67 into NixOS:master Nov 7, 2022
@wegank wegank deleted the aspelldicts-darwin branch November 7, 2022 14:08
@bjornfor
Copy link
Contributor

bjornfor commented Nov 7, 2022

Uhm, why does it rebuild so much on linux? (label 10.rebuild-linux: 101-500)

@wegank
Copy link
Member Author

wegank commented Nov 7, 2022

An earlier commit rebuilt all dictionaries on Linux. This was later fixed so that the label was removed.

@bjornfor
Copy link
Contributor

bjornfor commented Nov 7, 2022

Ah, thanks, I missed that detail :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjornfor bjornfor bjornfor approved these changes

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wegank @bjornfor