Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zsnes: pin to c++14 to fix build with gcc-11 #199932

Merged
merged 1 commit into from
Nov 7, 2022
Merged

zsnes: pin to c++14 to fix build with gcc-11 #199932

merged 1 commit into from
Nov 7, 2022

Conversation

trofi
Copy link
Contributor

@trofi trofi commented Nov 6, 2022 •
edited
Loading

Without the change build on master fails as:

jma/jma.h:67:28: error: ISO C++17 does not allow dynamic exception specifications
   67 |     jma_open(const char *) throw(jma_errors);
      |                            ^~~~~

ZHF: #199919

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@trofi
zsnes: pin to c++14 to fix build with gcc-11
eccb0a9 
Without the change build on `master` fails as:

    jma/jma.h:67:28: error: ISO C++17 does not allow dynamic exception specifications
       67 |     jma_open(const char *) throw(jma_errors);
          |                            ^~~~~

ZHF: NixOS#199919
@ofborg ofborg bot requested a review from svanderburg November 7, 2022 00:10
@AndersonTorres
Copy link
Member

Oh boy, this abandonware brings me memories...

@AndersonTorres AndersonTorres merged commit 6c49cc6 into NixOS:master Nov 7, 2022
@trofi trofi deleted the zsnes-zhf branch November 7, 2022 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svanderburg svanderburg Awaiting requested review from svanderburg

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trofi @AndersonTorres