Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmdstan: unbreak on aarch64-linux #203381

Merged
merged 1 commit into from
Dec 8, 2022

Conversation

wegank
Copy link
Member

@wegank wegank commented Nov 28, 2022

Description of changes

The package also had 1 Hydra failures on aarch64-darwin (where no binaries are provided), so #199919.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@wamserma
Copy link
Member

Result of nixpkgs-review pr 203381 run on aarch64-linux 1

1 package failed to build:
  • cmdstan

@wegank
Copy link
Member Author

wegank commented Nov 29, 2022

@wamserma Sorry for having x86_64 emulation enabled on my machine! Could you please review again?

@wamserma
Copy link
Member

Result of nixpkgs-review pr 203381 run on aarch64-linux 1

1 package built:
  • cmdstan

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/1524

@SuperSandro2000
Copy link
Member

For the next time: If you don't rebase on master before force pushing it is easier for me to see what exactly you changed and then merge it immediately.

@SuperSandro2000 SuperSandro2000 merged commit 47ecb22 into NixOS:master Dec 8, 2022
@wegank wegank deleted the cmdstan-aarch64-linux branch December 8, 2022 14:08
@wegank wegank mentioned this pull request Dec 28, 2022
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants