-
-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[staging-next] gnugrep: Fix build on Musl #234943
[staging-next] gnugrep: Fix build on Musl #234943
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This way it rebuilds on all platforms. We could instead use if .isMusl then foo else null;
Fixed. I have successfully built |
@ofborg build pkgsStatic.gnugrep |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rebuild fixed. I can now build pkgsStatic.gnugrep pkgsMusl.gnugrep
(ofBorg got the rebuild labels wrong; most likely confused by the force-push) |
Description of changes
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)