tuxedo-keyboard 3.1.4 -> 3.2.5 #236069
Merged
tuxedo-keyboard 3.1.4 -> 3.2.5 #236069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drupol
requested changes
Jun 7, 2023
|
|
||
| src = fetchFromGitHub { | ||
| owner = "tuxedocomputers"; | ||
| repo = "tuxedo-keyboard"; | ||
| rev = "v${version}"; | ||
| sha256 = "h6+br+JPEItym83MaVt+xo6o/zMtTv8+wsBoTeYa2AM="; | ||
| sha256 = "sha256-pSGshUyim06Sqkp5QFzhUjeIz/N3aORvVt6DEyzQLaU="; |
There was a problem hiding this comment.
Suggested change
| sha256 = "sha256-pSGshUyim06Sqkp5QFzhUjeIz/N3aORvVt6DEyzQLaU="; | |
| hash = "sha256-pSGshUyim06Sqkp5QFzhUjeIz/N3aORvVt6DEyzQLaU="; |
There was a problem hiding this comment.
I can change this, but do you have a reference for this being the preferred way?
There was a problem hiding this comment.
Find some discussions here: NixOS/rfcs#131
Some others here: NixOS/nix#7690
While there is no official url where you can find all the best practices rules, I invite you to check the merged PR where many committers are asking the same thing to contributors.
There was a problem hiding this comment.
thanks for the pointers!
xaverdh
force-pushed
the
tuxedo-keyboard-3.2.5
branch
from
92e7708
to
81a9774
Compare
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
new release
Things done
Tested with #231384 (applied on top of this). But probably needs more testing by people with different hardware!
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)