libxcrypt: Fix building with -march=native #237387
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using super.impureUseNativeOptimizations as an overlay for stdenv, libxcrypt fails building with -Werror=sign-conversion
Artturin
reviewed
Jul 3, 2023
Comment on lines
+27
to
28
| ] ++ lib.optionals (stdenv.hostPlatform.isMusl || stdenv.hostPlatform.libc == "bionic" || lib.hasInfix "-march=native" stdenv.cc.NIX_CFLAGS_COMPILE) [ | ||
| "--disable-werror" |
There was a problem hiding this comment.
IMO this should be made unconditional, Werror's for us are annoyances
There was a problem hiding this comment.
Would be easier than accumulating more conditionals. But please add a comment, that it is required for musl, android, march=native etc..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
When using super.impureUseNativeOptimizations as an overlay for stdenv, libxcrypt fails building with -Werror=sign-conversion
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)