Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustc: link libc++abi on Darwin #242283

Merged
merged 1 commit into from
Jul 8, 2023

Conversation

reckenrode
Copy link
Contributor

Description of changes

Fixes the build failure on staging-next. See #241951 (comment).

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@reckenrode
Copy link
Contributor Author

I’ve built this with a clang 16 stdenv, but there’s no reason it shouldn’t work with a clang 11 one.

Copy link
Contributor

@tjni tjni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM.

I wasn't able to find on Hydra an obvious error message. Would you mind adding what it was here for future reference?

@figsoda figsoda merged commit 44d074c into NixOS:staging-next Jul 8, 2023
12 checks passed
@reckenrode
Copy link
Contributor Author

I wasn't able to find on Hydra an obvious error message. Would you mind adding what it was here for future reference?

Sorry about that. I was mistaken re: Hydra. The failures were timeouts. I encountered an error with missing symbols due to libc++abi and assumed that was the issue. I’ll be more careful about making assumptions in the future.

I did try to reproduce the failure to get a stack trace, but now I can’t reproduce it with clang 11. It must have been an issue when using clang 16. 😑

@reckenrode reckenrode deleted the rust-darwin-hotfix branch July 9, 2023 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants