Limit exclusion of info/dir in builder.pl, fixes #242394

[league]

Description of changes

While trying to exclude a generated /share/info/dir in a package from symlinking into a profile, we also ended up excluding the Emacs info manual for dired-x. This change excludes only the dir file.

This entails rebuild-the-world, but I've verified with the following small flake that it can rebuild up to emacs and exhibits the desired fix. Just set inputs.nixpkgs.url to this commit vs base commit.

{
  outputs = { nixpkgs, ... }: {
    packages.x86_64-linux.builder-bug =
      let pkgs = nixpkgs.legacyPackages.x86_64-linux; in
      pkgs.buildEnv {
        name = "build-emacs";
        # Need emacs and one other package that puts something in /share/info.
        paths = [ pkgs.emacs29 pkgs.time ];
      };
  };
}

% ls result-before/share/info/dir*
zsh: no matches found: result-before/share/info/dir*

% ls result-after/share/info/dir*
result-after/share/info/dired-x.info.gz@

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 23.11 Release Notes (or backporting 23.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

[Artturin]

Should target staging, check CONTRIBUTING.md for how to rebase without mass pinging

commit title should be buildenv: Limit exclusion of info/dir

[Artturin]

used to include $ a6fcf45#diff-1967dcc359700a88592924a2e08cc397d4c8ccedec0717a5f96bafc33ece5e53L61

but it was removed in 2010 a6fcf45#diff-1967dcc359700a88592924a2e08cc397d4c8ccedec0717a5f96bafc33ece5e53R53

guessing he accidentally removed it when he changed the others to eq, while this was intentionally not changed

[league]

Thanks. Now I'm wondering why it shouldn't be $relName eq "/share/info/dir" unless there may be a package with info files under some other prefix.

[Artturin]

I checked with nix-index and there's some that aren't under toplevel share