fluidsynth: revert "move headers out to "dev" output, mans to "man"" #242635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 22e6b37. In NixOS#242623 OPNA2608 noticed that import path points to .dev output instead of .out output. I'm not sure if it's unintended as AFAIU `IMPORT_PATH` is about import stub libraries. Let's revert it for now and sort out the fallout later.
OPNA2608
approved these changes
Jul 10, 2023
There was a problem hiding this comment.
Fixes building bumped easyrpg-player with fluidsynth for me.
I think this should also be backported to staging-23.05: https://github.com/NixOS/nixpkgs/blob/nixos-23.05/pkgs/applications/audio/fluidsynth/default.nix#L17
12 tasks
|
Dropping in favour of #242657 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 22e6b37.
In #242623 OPNA2608 noticed that import path points to .dev output instead of .out output. I'm not sure if it's unintended as AFAIU
IMPORT_PATHis about import stub libraries.Let's revert it for now and sort out the fallout later.
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)