Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fluidsynth: Fix CMake config #242657

Merged
merged 1 commit into from
Jul 10, 2023
Merged

Commits on Jul 10, 2023

  1. fluidsynth: Fix CMake config

    Upstream is concatenating CMAKE_INSTALL_LIBDIR onto CMAKE_INSTALL_PREFIX to get
    a directory to use for the install_name on Darwin. This is not the right way of
    making CMAKE_INSTALL_LIBDIR absolute.
    
    The config was first set up for breakage when the CMAKE_INSTALL_LIBDIR was made relative,
    in order to work around the wrong concatenation. This caused the _IMPORT_PREFIX to be
    computed by walking up the directory tree from the config file, instead of using
    the absolute CMAKE_INSTALL_LIBDIR.
    
    Then outputs were introduced to the derivation and the config was moved to a different
    output. Now the prefix it walks up to is the wrong prefix, and the config is busted.
    
    Fix by reverting the original workaround so we have an absolute CMAKE_INSTALL_LIBDIR,
    and pulling a patch that fixes the bad concatenation.
    OPNA2608 committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    f43a46f View commit details
    Browse the repository at this point in the history