Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

graphene: disable broken NEON support on armv7l-linux #263817

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

misuzu
Copy link
Contributor

@misuzu misuzu commented Oct 27, 2023

Description of changes

Fix build failure on armv7l-linux

[78/78] Generating src/Graphene-1.0.typelib with a custom command
running tests
check flags: ''
 1/19 euler                    OK              0.07s   10 subtests passed
 2/19 frustum                  OK              0.05s   21 subtests passed
 3/19 matrix                   OK              0.08s   70 subtests passed
 4/19 plane                    OK              0.07s   13 subtests passed
 5/19 point                    OK              0.10s   24 subtests passed
 6/19 point3d                  OK              0.11s   36 subtests passed
 7/19 quad                     OK              0.14s   12 subtests passed
 8/19 quaternion               OK              0.11s   24 subtests passed
 9/19 ray                      OK              0.10s   26 subtests passed
10/19 box                      ERROR           0.34s   killed by signal 7 SIGBUS
>>> LD_LIBRARY_PATH=/build/source/build/src MALLOC_PERTURB_=136 MUTEST_OUTPUT=tap /build/source/build/tests/box

11/19 rect                     OK              0.14s   69 subtests passed
12/19 simd                     OK              0.15s   25 subtests passed
13/19 size                     OK              0.14s   17 subtests passed
14/19 sphere                   OK              0.11s   17 subtests passed
15/19 triangle                 OK              0.14s   56 subtests passed
16/19 vec2                     OK              0.16s   37 subtests passed
17/19 vec3                     OK              0.13s   51 subtests passed
18/19 vec4                     OK              0.09s   63 subtests passed
19/19 introspection.py         OK              0.21s   1 subtests passed

Ok:                 18  
Expected Fail:      0   
Fail:               1   
Unexpected Pass:    0   
Skipped:            0   
Timeout:            0   

Full log written to /build/source/build/meson-logs/testlog.txt

See also:
ebassi/graphene#215
archlinuxarm/PKGBUILDs#1977

Things done

  • Built on platform(s)
    • armv7l-linux
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/1189

@wegank wegank merged commit a1faa83 into NixOS:master Oct 31, 2023
25 checks passed
@misuzu misuzu deleted the graphene-armv7l-fix branch December 8, 2023 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants