Python package fixes #311156
Python package fixes #311156
Conversation
There was a problem hiding this comment.
Looks okay to me. I do not understand why you have taken on you to change the with lib; from meta, but I am not one to bikeshed on these things.
Thanks for the work.
I will wait a bit to let others review it too. Do not hesitate to ping me if it is not merged withing the next few days.
There was a problem hiding this comment.
I recommend submitting one PR per package next time.
In #311054, hexa says
On top of that, packages relying on nose have largely been unmaintained and might be dead leafs or using another test framework entirely. It is also to be expected that they need to be converted to the PEP517 builder in the process of fixing them.
This indicates that we need to change the packages significantly.
pyrox0
force-pushed
the
nose-removal-1
branch
2 times, most recently
from
f679dd2
to
bfca717
Compare
|
Updated to fix previous merge conflicts. |
pyrox0
force-pushed
the
nose-removal-1
branch
2 times, most recently
from
9752915
to
4724e85
Compare
|
This previously had changes related to Capstone's Python bindings. Those have been dropped as out-of-scope for this PR, and can be resubmitted later once upstream fully drops distutils in a later release. |
|
FYI binwalk got updated to fork in #326295 |
They require privilaged filesystem access(/proc), so they do not run in Nix's sandbox.
See upstream PR NixOS#165 for details
Updates to the community supported fork of binwalk, and modernizes the code to modern Nix Python packaging standards.
|
merge conflict fixed. |
|
Closing since this has been superseded by multiple other PRs and it's no longer needed. |
Fixes a few packages that are broken on python 3.12, mainly related to their usage of
nose, by disabling tests or otherwise migrating them topytestCheckHook.This also migrates binwalk to the supported fork at OSPG/binwalk, which also fixes a
noseissue by it migrating topytest.Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.