Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python312Packages.spark-parser: drop nose dependency #330001

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

Sigmanificient
Copy link
Member

@Sigmanificient Sigmanificient commented Jul 25, 2024

Description of changes

Part of:

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Sigmanificient Sigmanificient changed the title spark-parser: drop nose dependency python312Packages.spark-parser: drop nose dependency Jul 25, 2024
@ofborg ofborg bot requested a review from 7c6f434c July 25, 2024 23:59
@7c6f434c 7c6f434c merged commit 16baf63 into NixOS:master Jul 26, 2024
27 of 29 checks passed
Comment on lines +22 to +27
nativeCheckInputs = [ unittestCheckHook ];
unittestFlagsArray = [
"-s"
"test"
"-v"
];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does pytestCheckHook not work here? We’d generally prefer it when it does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants