Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python312Package.safe: drop #330404

Merged
merged 1 commit into from
Jul 31, 2024
Merged

python312Package.safe: drop #330404

merged 1 commit into from
Jul 31, 2024

Conversation

Sigmanificient
Copy link
Member

@Sigmanificient Sigmanificient commented Jul 27, 2024

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@emilazy
Copy link
Member

emilazy commented Jul 28, 2024

I think we can drop this: unmaintained for 5 years, password strength checker with a fairly unsophisticated methodology, concerning use of pickle, only one reverse dependency on PyPI. We have better options in‐tree (e.g. zxcvbn).

Copy link
Member

@emilazy emilazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit message and PR title need updating.

@emilazy
Copy link
Member

emilazy commented Jul 28, 2024

P.S. 330404 seems appropriate :)

@Sigmanificient Sigmanificient changed the title python312Package.safe: drop nose dependency python312Package.safe: drop nose Jul 28, 2024
@natsukium natsukium changed the title python312Package.safe: drop nose python312Package.safe: drop Jul 29, 2024
@natsukium
Copy link
Member

Result of nixpkgs-review pr 330404 at ec7e7a0f run on x86_64-linux 1

1 package built successfully:
  • nixpkgs-manual

@emilazy
Copy link
Member

emilazy commented Jul 29, 2024

Hmm, why did it rebuild the manual…?

Waiting on the commit message to be updated before merging.

@natsukium
Copy link
Member

Hmm, why did it rebuild the manual…?

I'm not sure, but it looks fine.

@emilazy emilazy merged commit abcd995 into NixOS:master Jul 31, 2024
23 checks passed
@Sigmanificient Sigmanificient deleted the safe branch July 31, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants