Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python312Packages.prison: drop nose dependency #330700

Merged
merged 1 commit into from
Jul 28, 2024

Conversation

Sigmanificient
Copy link
Member

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Copy link
Member

@emilazy emilazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 330700 run on x86_64-linux 1

6 packages marked as broken and skipped:
  • apache-airflow
  • apache-airflow.dist
  • python311Packages.flask-appbuilder
  • python311Packages.flask-appbuilder.dist
  • python312Packages.flask-appbuilder
  • python312Packages.flask-appbuilder.dist
5 packages built:
  • nixpkgs-manual
  • python311Packages.prison
  • python311Packages.prison.dist
  • python312Packages.prison
  • python312Packages.prison.dist

The only in‐tree user is currently marked broken because of SQLAlchemy and dpgaspar/Flask-AppBuilder#2241 seems stalled, but hopefully that will change at some point.

@emilazy emilazy merged commit f27b62e into NixOS:master Jul 28, 2024
27 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants