python3Packages.nose3: drop #330741
Merged
python3Packages.nose3: drop #330741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| license = licenses.mpl20; | ||
| maintainers = [ maintainers.willibutz ]; | ||
| platforms = platforms.unix; | ||
| sourceProvenance = [ lib.sourceTypes.fromSource ]; |
There was a problem hiding this comment.
source should be not set as otherwise we had a lot of code deduplication
There was a problem hiding this comment.
See #329470 (comment) for my (and others’) thoughts on that. (If sourceProvenance = [ lib.sourceTypes.fromSource ]; is redundant, so is sourceProvenance = [ lib.sourceTypes.fromSource lib.sourceTypes.binaryNativeCode ]; and arguably even sourceProvenance = [ lib.sourceTypes.binaryNativeCode ];, not to mention license = lib.licenses.free; which nobody would argue for dropping.)
emilazy
force-pushed
the
push-rlvumrtyxrmk
branch
from
6e30c10
to
036cfae
Compare
emilazy
force-pushed
the
push-rlvumrtyxrmk
branch
from
036cfae
to
15f6dd3
Compare
|
Rebased. (I guess I’ll have to rebase #330725 afterwards too…) |
|
Oh, sorry, I merged the #330725 first. I'll rebase. |
These exercise Gixy through the NixOS nginx module.
natsukium
force-pushed
the
push-rlvumrtyxrmk
branch
from
15f6dd3
to
9b7e7d7
Compare
|
I think we should be good to merge this. |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
If nose is so good why isn’t there a nose3?
#326513
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.