-
-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python312Packages.hkdf: Drop nose dependency; modernize #330769
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An HKDF implementation is probably one of the less concerning cryptography libraries to not be updated for a decade, but I still don’t feel great about this.
autobahn
only requires it (and spake2
) optionally for some dead cryptocurrency thing that we should probably drop, but magic-wormhole
depends on this through spake2
. It looks like magic-wormhole
was removed by Fedora along with hkdf
and spake2
in favour of the Rust version from the same upstream.
I’m going to ask around about this, but it might be better just to drop this if we find the Rust version of Magic Wormhole to be an acceptable replacement.
Sounds like a plan, I'll make this into a draft till there's a conclusion on that front. |
After engaging with upstream, it looks like they’re actively maintaining |
The changes to |
There’s new releases of Did you want to handle the bumps and dropping |
Working on doing those bumps and dropping the package now. Edit: seems like the bumps have already been done, just dropped the |
Any progress on this? I’m holding out hope that we can rush the last few packages in the few days before the 24.11 freeze 😅 |
Actually I misread the release schedule and we have until the 25th to finish the job, so don’t feel unduly rushed! |
Description of changes
Part of #326513
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.