python312Packages.locationsharinglib: drop nose dependency; modernize #330786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabaff
reviewed
Jul 29, 2024
pyrox0
force-pushed
the
denose/locationsharinglib
branch
from
1024481
to
c745026
Compare
emilazy
reviewed
Aug 9, 2024
Comment on lines
27
to
31
| substituteInPlace setup.py \ | ||
| --replace "tests_require=test_requirements" "tests_require=[]" | ||
| --replace-fail "tests_require=test_requirements" "tests_require=[]" | ||
| substituteInPlace requirements.txt \ | ||
| --replace "coloredlogs>=15.0.1" "coloredlogs" \ | ||
| --replace "pytz>=2023.3" "pytz" | ||
| --replace-fail "coloredlogs>=15.0.1" "coloredlogs" \ | ||
| --replace-fail "pytz>=2023.3.post1" "pytz" |
There was a problem hiding this comment.
Just checking if pythonRelaxDeps/pythonRemoveDeps might work here?
There was a problem hiding this comment.
Just tested, it seems to work without this patch, so I've removed it.
pyrox0
force-pushed
the
denose/locationsharinglib
branch
from
c745026
to
3621f09
Compare
emilazy
approved these changes
Aug 10, 2024
There was a problem hiding this comment.
Result of nixpkgs-review pr 330786 run on aarch64-linux 1
4 packages built:
- python311Packages.locationsharinglib
- python311Packages.locationsharinglib.dist
- python312Packages.locationsharinglib
- python312Packages.locationsharinglib.dist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Part of #326513
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.