-
-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python312Packages.pycontracts: drop #330791
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This isn’t used by anything and upstream seems pretty dead; maybe it’d be best to drop it rather than patching it up a bunch? If there’s a reason to keep it I’d feel better about a proper .patch
as this goes beyond my substituteInPlace
comfort zone.
I'll change this to drop instead, good call since there is a lot of patching. |
99a88ac
to
5d30219
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can merge when ofborg-eval passes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Result of nixpkgs-review pr 330791
run on aarch64-linux 1
Description of changes
Upstream is abandoned and this package no longer works on modern python versions. Since nothing else depends on it, drop the package.
Part of #326513
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.