-
-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python3Packages.scikit-fuzzy: unstable-2022-11-07 -> unstable-2023-09-14 #330854
Conversation
@emilazy getting this weird build failure from the checkPhase
|
Looks like some issue with running tests out of tree. It’s beyond my expertise without doing a bunch of digging; hopefully someone else can take a look. |
I'll look at the build failures. Looks good otherwise. |
I figured, we gotta remove the build dir during the checkPhase. I added the following: checkPhase = ''
rm -rf build
''; |
b144c46
to
ed9d572
Compare
ed9d572
to
72ddb48
Compare
I guess that'd be more appropriate, yeah. Also, I just tested that we can run `pytest skfuzzy` in the checkPhase to point to the appropriate directory.
|
The current version using |
72ddb48
to
f89a28b
Compare
f89a28b
to
ed734e5
Compare
done |
@ofborg build python312Packages.scikit-fuzzy python312Packages.intensity-normalization |
Description of changes
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.