-
-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ledger-autosync: fix build with Python 3.12 and don't propagate ledger and hledger #334202
Conversation
b394acf
to
29e2647
Compare
What do we need 3.11 for here? Upstream doesn’t actually mention nose at all, so I was hoping we could keep this running on 3.12 and move it over to |
for |
29e2647
to
24f82c0
Compare
True. I dropped the nose dependency. |
Sorry, should have read more closely… Seems reasonable (albeit unfortunate) to me, but since upstream uses pytest, can we at least drop the nose use here? Edit: Ah, you’re ahead of me! |
The alternative to using |
Perhaps we should just bump to the current Git HEAD. The conversion to pytest was actually after the latest release, and upstream was planning on cutting a release in July. That hasn’t yet happened, but there’s been a lot of clean‐up and fixes since, so if upstream thought it was ready for release I say we should just bump. (I was looking at these packages a while ago but paged out most of the memories…) |
24f82c0
to
7985795
Compare
The one available in $PATH is automatically selected. Also remove other superfluous dependencies.
7985795
to
9faf61f
Compare
I think this makes sense given the state of the project. I'm fine merging the PR as it is though. What do you say @dotlambda? |
Let's give upstream a little more time to cut a release before we use the git HEAD. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes are great, thank you for your work. I'm fine merging that or waiting for upstream to release or using git HEAD.
Description of changes
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.