Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nextcloud30: init at 30.0.0; nextcloud30Packages: init #342521

Merged
merged 7 commits into from
Oct 1, 2024

Conversation

onny
Copy link
Contributor

@onny onny commented Sep 17, 2024

Description of changes

Changelog https://nextcloud.com/blog/nextcloud-hub9/

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

nixos/modules/services/web-apps/nextcloud.nix Show resolved Hide resolved
pkgs/servers/nextcloud/default.nix Outdated Show resolved Hide resolved
pkgs/servers/nextcloud/default.nix Outdated Show resolved Hide resolved
pkgs/servers/nextcloud/default.nix Outdated Show resolved Hide resolved
@onny
Copy link
Contributor Author

onny commented Sep 21, 2024

Thank you @dotlambda fixed the issues

@onny onny force-pushed the nextcloud-update10 branch 2 times, most recently from 35a6d34 to 934c6b7 Compare September 23, 2024 15:15
@onny
Copy link
Contributor Author

onny commented Sep 23, 2024

@Ma27 hopefully addressed the remaining issues :)

@Ma27
Copy link
Member

Ma27 commented Sep 24, 2024

WIll take another look today.

@Ma27
Copy link
Member

Ma27 commented Sep 25, 2024

WIll take another look today.

Sorry, will take me until tomorrow.

@Ma27 Ma27 self-assigned this Oct 1, 2024
@ofborg ofborg bot requested a review from Ma27 October 1, 2024 11:53
Copy link
Member

@Ma27 Ma27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current state is working fine for me (except I'm unhappy that maps isn't ready for nc30 yet 😢 ).

@Ma27 Ma27 mentioned this pull request Oct 1, 2024
13 tasks
@ofborg ofborg bot requested a review from Ma27 October 1, 2024 12:18
@Ma27 Ma27 merged commit 25fe330 into NixOS:master Oct 1, 2024
25 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants