Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib/systems/architectures: add sapphirerapids/emeraldrapids #347061

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

lib/systems/architectures: add sapphirerapids/emeraldrapids #347061

wants to merge 1 commit into from
+8 −0

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Oct 7, 2024 •
edited
Loading

For reference: https://en.wikichip.org/wiki/intel/microarchitectures/sapphire_rapids
/proc/cpuinfo for sapphirerapids: https://gist.github.com/Mic92/a04ce8f76efded149c19351d649670d7
/proc/cpuinfo for emeraldrapids: https://gist.github.com/Mic92/54cd09557eff6edd2fe941cb78a92945

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: lib The Nixpkgs function library label Oct 7, 2024
@Mic92 Mic92 changed the title lib/systems/architectures: add sapphirerapids lib/systems/architectures: add sapphirerapids/emeraldrapids Oct 7, 2024
@Mic92
Copy link
Member Author

Mic92 commented Oct 7, 2024

Tested on real hardware here: TUM-DSE/doctor-cluster-config#200

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314 Ericson2314 is a code owner

@alyssais alyssais Awaiting requested review from alyssais alyssais is a code owner

Assignees
No one assigned
Labels
6.topic: lib The Nixpkgs function library 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Mic92