Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace overridePythonAttrs with overrideArgs, add for Rust and Go as well #46842

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Replace overridePythonAttrs with overrideArgs, add for Rust and Go as well #46842

wants to merge 3 commits into from

Commits on Oct 21, 2018

  1. buildPythonPackage: rename overrideArgs 

    This will allow consistency between override functions for various
language-specific build functions.
    @alyssais
    alyssais committed Oct 21, 2018
    Configuration menu
    Copy the full SHA
    0cdd27f View commit details
    Browse the repository at this point in the history

  2. buildRustPackage: add overrideArgs to output 

    This allows, eg, specifying a custom src to use a different version
of a package, like overrideAttrs does for normal packages, or
overrideArgs for Python packages.
    @alyssais
    alyssais committed Oct 21, 2018
    Configuration menu
    Copy the full SHA
    ae0b649 View commit details
    Browse the repository at this point in the history

  3. buildGoPackage: add overrideArgs 

    This allows, eg, patches that require extraSrcs to be applied to Go
packages. It's similar to `overrideArgs` in `buildPythonPackage` and
`buildRustPackage`.
    @alyssais
    alyssais committed Oct 21, 2018
    Configuration menu
    Copy the full SHA
    5900b6a View commit details
    Browse the repository at this point in the history