-
-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
qt59.qtwebkit: fix build on Darwin #50521
Conversation
Huh, I already fixed this. |
… huh. Maybe I wasn't up to date when it was broken for me, and then since I changed it in a different place, git just combined the two when I updated. |
Oh, bet I know what it is! My fix would have propagated the cf-private dependency (bad), and that would have fixed qtwebkit, which is what I use qtbase for. So what actually needs to happen is qtwebkit needs to depend on cf-private as well. I'll change the PR to do that. |
30b28de
to
d89a2a2
Compare
Ah, I might have missed that. I tried to fix everything that's important to get master back in an ok state but looking into swift-corelibs is probably the proper solution. |
Success on aarch64-linux (full log) Attempted: qt5.qtwebkit Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: qt5.qtwebkit Partial log (click to expand)
|
@LnL7 I just build this locally, and now it fails because it can't find |
@GrahamcOfBorg build qt5.qtwebkit |
Success on aarch64-linux (full log) Attempted: qt5.qtwebkit Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: qt5.qtwebkit Partial log (click to expand)
|
Failure on x86_64-darwin (full log) Attempted: qt5.qtwebkit Partial log (click to expand)
|
Oh, it'll need to be qt59.qtwebkit – it's the only Darwin-compatible version right now. See #48700. |
d89a2a2
to
874468f
Compare
Success on aarch64-linux (full log) Attempted: qt59.qtwebkit Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: qt59.qtwebkit Partial log (click to expand)
|
@GrahamcOfBorg build qt59.qtwebkit |
Success on x86_64-linux (full log) Attempted: qt59.qtwebkit Partial log (click to expand)
|
Success on aarch64-linux (full log) Attempted: qt59.qtwebkit Partial log (click to expand)
|
Timed out, unknown build status on x86_64-darwin (full log) Attempted: qt59.qtwebkit Partial log (click to expand)
|
@alyssais Does this latest commit work for you? I had a successful build. |
Yep, this works for me. |
Not sure if this is related, but qtwebkit currently fails for darwin: https://github.com/NixOS/nixpkgs/pull/52613/checks?check_run_id=43642188 |
Looks like that is already #51846 |
@timokau [1] https://hydra.nixos.org/job/nixpkgs/trunk/qt59.qtwebkit.x86_64-darwin |
Motivation for this change
Broken by #49768.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)