Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Ability to save and load StatsForecast #667

Merged
merged 21 commits into from
Oct 23, 2023
Merged

[FEAT] Ability to save and load StatsForecast #667

merged 21 commits into from
Oct 23, 2023

Conversation

akmalsoliev
Copy link
Contributor

methods will save and load StatsForecast class with all the models.

Under the condition that model(s) are too big the user confirmation prompt will be asked, unless the variable prompt will be set to "Y"

Matching `environment.yml`
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

statsforecast/core.py Outdated Show resolved Hide resolved
statsforecast/core.py Outdated Show resolved Hide resolved
statsforecast/core.py Outdated Show resolved Hide resolved
statsforecast/core.py Outdated Show resolved Hide resolved
statsforecast/core.py Outdated Show resolved Hide resolved
statsforecast/core.py Outdated Show resolved Hide resolved
Copy link
Member

@jmoralez jmoralez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add a test in the notebook verifying that the model can be saved/loaded correctly and produces the same predictions.

statsforecast/core.py Outdated Show resolved Hide resolved
statsforecast/core.py Outdated Show resolved Hide resolved
statsforecast/core.py Outdated Show resolved Hide resolved
statsforecast/core.py Outdated Show resolved Hide resolved
from `FittedModels_` to `StatsForecast_`

Co-authored-by: José Morales <jmoralz92@gmail.com>
@akmalsoliev
Copy link
Contributor Author

Please also add a test in the notebook verifying that the model can be saved/loaded correctly and produces the same predictions.

Constructed a hidden cell that does that, all the modification requests are resolved in the latest push.

statsforecast/core.py Outdated Show resolved Hide resolved
statsforecast/core.py Outdated Show resolved Hide resolved
statsforecast/core.py Outdated Show resolved Hide resolved
statsforecast/core.py Outdated Show resolved Hide resolved
statsforecast/core.py Outdated Show resolved Hide resolved
statsforecast/core.py Outdated Show resolved Hide resolved
statsforecast/core.py Outdated Show resolved Hide resolved
statsforecast/core.py Outdated Show resolved Hide resolved
statsforecast/core.py Outdated Show resolved Hide resolved
statsforecast/core.py Outdated Show resolved Hide resolved
@jmoralez jmoralez merged commit 0e25b61 into Nixtla:main Oct 23, 2023
20 checks passed
@akmalsoliev akmalsoliev deleted the save_model branch October 23, 2023 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants