Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate http tunnel #39

Merged
merged 27 commits into from
Oct 20, 2020
Merged

Integrate http tunnel #39

merged 27 commits into from
Oct 20, 2020

Conversation

mpetrun5
Copy link
Member

@mpetrun5 mpetrun5 commented Oct 12, 2020 •
edited
Loading

Short description of work done

Added http tunnel connection with register token to load balancer

PR Checklist

  • I have run linter localy
  • I have run unit and integration tests locally
  • Rebased to master branch / merged master

Changes

  • added http tunnel to load balancer
  • changed load balancer register to return register response wiht token and tunnel_url
  • use tunnel url from register response for connecting

Issues

Closes: #38

mpetrunic
mpetrunic requested changes Oct 13, 2020
View reviewed changes
cmd/start.go Outdated Show resolved Hide resolved
internal/run/run_test.go Show resolved Hide resolved
mpetrunic
mpetrunic reviewed Oct 13, 2020
View reviewed changes
internal/run/run.go Outdated Show resolved Hide resolved
internal/tunnel/tunnel.go Outdated Show resolved Hide resolved
mpetrunic
mpetrunic reviewed Oct 14, 2020
View reviewed changes
internal/tunnel/tunnel.go Outdated Show resolved Hide resolved
internal/tunnel/tunnel.go Outdated Show resolved Hide resolved
@mpetrun5 mpetrun5 marked this pull request as draft October 14, 2020 12:33
@mpetrun5
Copy link
Member Author

@MakMuftic @mpetrunic
This is still WIP
We should first merge final tunnel PR on vedran and then I will finish this

@mpetrun5 mpetrun5 marked this pull request as ready for review October 19, 2020 11:15
mpetrunic
mpetrunic previously approved these changes Oct 19, 2020
View reviewed changes
MakMuftic
MakMuftic previously approved these changes Oct 19, 2020
View reviewed changes
Copy link
Member

@MakMuftic MakMuftic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@mpetrun5 mpetrun5 changed the base branch from master to dev October 19, 2020 15:03
@mpetrun5 mpetrun5 dismissed stale reviews from MakMuftic and mpetrunic October 19, 2020 15:03

The base branch was changed.

@mpetrun5 mpetrun5 merged commit 5017c1c into dev Oct 20, 2020
@mpetrun5 mpetrun5 deleted the mpetrun5/http-tunnel branch October 22, 2020 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpetrunic mpetrunic mpetrunic approved these changes

@MakMuftic MakMuftic MakMuftic approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement opening tunnel on daemon side
3 participants
@mpetrun5 @mpetrunic @MakMuftic