Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ws endpoint check on start #62

Merged
merged 5 commits into from
Jan 26, 2021
Merged

Add ws endpoint check on start #62

merged 5 commits into from
Jan 26, 2021

Conversation

MakMuftic
Copy link
Member

@MakMuftic MakMuftic commented Jan 26, 2021 •
edited
Loading

Add check if the daemon is able to connect to ws endpoint on start

Release v0.3.3

PR Checklist

  • I have run linter localy
  • I have run unit and integration tests locally
  • Rebased to master branch / merged master
  • Updated CHANGELOG.md

Changes

  • try to connect to ws endpoint on start
  • fix default value for node ws endpoint

Issues

Closes #61

@MakMuftic MakMuftic marked this pull request as draft January 26, 2021 12:34
mpetrunic
mpetrunic previously approved these changes Jan 26, 2021
View reviewed changes
@mpetrunic
Copy link
Member

conflicts

@MakMuftic
Copy link
Member Author

@mpetrun5 @mpetrunic This is also v0.3.3 release

@MakMuftic MakMuftic marked this pull request as ready for review January 26, 2021 12:46
@mpetrunic mpetrunic merged commit 90d9487 into master Jan 26, 2021
@mpetrunic mpetrunic deleted the mmuftic/add-ws-check branch January 26, 2021 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpetrunic mpetrunic mpetrunic approved these changes

@mpetrun5 mpetrun5 mpetrun5 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check if daemon can connect on ws endpoint
3 participants
@MakMuftic @mpetrunic @mpetrun5